Skip to content
Snippets Groups Projects
Commit ea76c49b authored by Hana's avatar Hana Committed by Hyang-Ah Hana Kim
Browse files

[release] src/goMain: fix the exception caused by invalid version string

https://go-review.googlesource.com/c/vscode-go/+/289191 made
showGoWelcomePage pass an empty string to shouldShowGoWelcomePage
and causes it to fail. Do the null check on the coerced semver.

Change-Id: Ibc5d9684e153571e7e6507f533367a128952c9ac
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/289969


Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: default avatarSuzy Mueller <suzmue@golang.org>
(cherry picked from commit feee65b4)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/290109


Reviewed-by: default avatarRebecca Stambler <rstambler@golang.org>
parent b33ce83f
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment