@@ -8,18 +8,28 @@ The modifications we made are available at https://github.com/scossin/Achilles/c
...
@@ -8,18 +8,28 @@ The modifications we made are available at https://github.com/scossin/Achilles/c
## Oracle issues
## Oracle issues
There are currently 2 open issues with Oracle database:
There are currently 2 open issues with Oracle database:
- https://github.com/OHDSI/Achilles/issues/598: Achilles create table doesn't work. [Our fix](https://github.com/scossin/Achilles/commit/f918ba5fb58dbea0e2e19cb6a279ce1d3dc41022) was to replace '' as by cast('' as varchar(255)) in the table creation queries.
- https://github.com/OHDSI/Achilles/issues/598: Achilles _create table analysis_ doesn't work. [Our fix](https://github.com/scossin/Achilles/commit/f918ba5fb58dbea0e2e19cb6a279ce1d3dc41022) was to replace
```sql
''as
```
by
```sql
cast(''asvarchar(255))
```
in the SQL query.
- https://github.com/OHDSI/Achilles/issues/600: query 109 fails because SUBSTRING doesn't exist in Oracle. [Our fix](https://github.com/scossin/Achilles/commit/75008f4a6326a8f1a3db92dc260df8c037496573) was to replace substring by substr
- https://github.com/OHDSI/Achilles/issues/600: query 109 fails because SUBSTRING doesn't exist in Oracle. [Our fix](https://github.com/scossin/Achilles/commit/75008f4a6326a8f1a3db92dc260df8c037496573) was to replace substring by substr
## Package execution
## Package execution
The script we executed to run Achilles is available here: https://github.com/scossin/Achilles/blob/cdw_bordeaux/codeToRun.R
The script we executed to run Achilles is available here: https://github.com/scossin/Achilles/blob/cdw_bordeaux/codeToRun.R
The script ""./getConnectionDetails.R" (not in the repository). returns a connectionDetails object to connect to the database.
The script "./getConnectionDetails.R" (not in the repository). returns a connectionDetails object to connect to the database.
The password is stored and encrypted by the [keyring](https://cran.r-project.org/web/packages/keyring/index.html) package.
The password is stored and encrypted by the [keyring](https://cran.r-project.org/web/packages/keyring/index.html) package.
**All the default analysis run successfully**.
**All the default analysis run successfully**.
### errors with non-default analysis
We have a ORA-01652 error (unable to extend temp segment in tablespace) when running Achilles analysis id 424, 624, 724, 1824: the Oracle database run out of memory with 256 go avaivable in our TEMP tablespace.
We have a ORA-01652 error (unable to extend temp segment in tablespace) when running Achilles analysis id 424, 624, 724, 1824: the Oracle database run out of memory with 256 go avaivable in our TEMP tablespace.
These queries find and rank the top 10 co-occurring condition (424) / procedures (624) / drugs (724) / measurement (1824).
These queries find and rank the top 10 co-occurring condition (424) / procedures (624) / drugs (724) / measurement (1824).
To do so, these queries perform an inner join on person_id within the same_table. This inner join takes a lot of memory since these tables contain million of rows. The limited memory resource in TEMP_IAM (256 go) can't store the results of this inner join.
To do so, these queries perform an inner join on person_id within the same_table. This inner join takes a lot of memory since these tables contain million of rows. The limited memory resource in TEMP_IAM (256 go) can't store the results of this inner join.
This issue happened in other databases and was discussed here: https://github.com/OHDSI/Achilles/issues/425
This issue happened in other databases and was discussed here: https://github.com/OHDSI/Achilles/issues/425